fix(atomic): fix build to include missing assets in CDN #6772
Merged
SimonMilord merged 6 commits intomainfrom Jan 5, 2026
Merged
fix(atomic): fix build to include missing assets in CDN #6772SimonMilord merged 6 commits intomainfrom
SimonMilord merged 6 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build order issue where the sparkles.svg asset was missing from the CDN bundle, causing the atomic-insight-generate-answer-button component to fail with a 404 error. The fix moves the asset preparation scripts (copy-assets.mjs and list-assets.mjs) earlier in the build:stencil-lit script execution, ensuring assets are available before the rollup bundler copies them to the CDN directory.
Key Changes
- Inlined
node ./scripts/copy-assets.mjs && node ./scripts/list-assets.mjsinto thebuild:stencil-litscript, positioning them before therollup -c rollup.config.jsstep - This ensures
sparkles.svgand other assets are copied todist/atomic/assets/before rollup attempts to bundle them into the CDN
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Marking as draft because of the disclaimer:
|
erocheleau
approved these changes
Dec 19, 2025
louis-bompart
requested changes
Jan 5, 2026
Collaborator
louis-bompart
left a comment
There was a problem hiding this comment.
Overall LGTM, tho questions/changes to be addressed before moving up
louis-bompart
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFINT-6534
IN THIS PR:
Trying to use the atomic-insight-generate-answer button in an atomic page is giving the following error:
The issue:
The build order seems to call the rollup script that copies the assets for the CDN before the assets are loaded/copied in the
build:stencil-litscript.We call
build:stencil-litwhich includes therollup -c rollup.config.jswhich copies the assets for the CDN, but then thebuild:copy-assets&build:list-assetswhich loads and saves thesparkles.svgare not yet called. So the CDN does not include the svg.The solution:
Main Changes in turbo.json:
Why:
This enforces the required build order:
Additional Cleanups:
Main Changes in package.json:
Why:
Proof it works:
The CDN without the fix:

The CDN with the fix:
